Nice batch of comments, Matt. Gary ---------- Forwarded message ---------- From: Matt Sicker <notificati...@github.com> Date: Mon, Apr 24, 2017 at 1:14 PM Subject: Re: [apache/logging-log4j2] Add a new LuceneAppender which writes logging events to a lucene index library. (#74) To: apache/logging-log4j2 <logging-log...@noreply.github.com> Cc: Gary Gregory <garydgreg...@gmail.com>, Comment < comm...@noreply.github.com>
*@jvz* commented on this pull request. ------------------------------ In log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/lucene/ LuceneAppender.java <https://github.com/apache/logging-log4j2/pull/74#discussion_r113044694>: > +import > org.apache.logging.log4j.core.config.plugins.validation.constraints.Required; +import org.apache.logging.log4j.util.Strings; +import org.apache.lucene.document.Document; +import org.apache.lucene.document.Field; +import org.apache.lucene.document.LongField; +import org.apache.lucene.document.StringField; +import org.apache.lucene.document.TextField; +import org.apache.lucene.index.IndexWriter; +import org.apache.lucene.index.IndexWriterConfig; +import org.apache.lucene.search.NumericRangeQuery; +import org.apache.lucene.store.FSDirectory; + +/** + * This Appender writes logging events to a lucene index library. It takes a list of + * {@link IndexField} with which determines which fields are written to the index library. + * <Lucene name="lucene" ignoreExceptions="true" target="/target/lucene/index"> Might want to surround this with something like <pre>{@code ... }</pre> or however it'd be best formatted. XML doesn't work well in javadocs ;) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/apache/logging-log4j2/pull/74#pullrequestreview-34404866>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABIfN7sX1FV-XyD58YeYZ-gCednX7jAsks5rzQKwgaJpZM4NFuBc> . -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> JUnit in Action, Second Edition <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> Spring Batch in Action <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
