On Mon, May 22, 2017 at 8:54 AM, Mikael Ståldal <mi...@apache.org> wrote:
> SocketAppender uses "with" like this:
>
> public B withSslConfiguration(final SslConfiguration sslConfiguration) {
> this.sslConfiguration = sslConfiguration;
> return asBuilder();
> }
>
> is that wrong?
>
In my mind, yes, but it is more confusing than "wrong".
Gary
>
> On 2017-05-22 17:50, Gary Gregory wrote:
>
>> I like "with" for methods that return a new instance and "set" for those
>> that do not.
>>
>> Since most if not all of our builders don't create new instances on setter
>> calls I would go with "set".
>>
>> 2c,
>> Gary
>>
>> Gary
>>
>> On May 22, 2017 8:36 AM, "Mikael Ståldal" <mi...@apache.org> wrote:
>>
>> What is the preferred naming convention for plugin builder setter methods?
>>> It is setXXX or withXXX? I see both being used in the code base.
>>>
>>> I wonder which to use for the upcoming HttpAppender (LOG4J2-1442).
>>>
>>>
>>>
>>>
>
--
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
