I just pushed an update that fixes the currently failing tests for JMS and Flume.
Gary On Sun, Jul 30, 2017 at 1:59 PM, Gary Gregory <[email protected]> wrote: > On Sun, Jul 30, 2017 at 1:48 PM, Gary Gregory <[email protected]> > wrote: > >> * I think the new logic to avoid logging calls blowing up >> (ConcurrentModificationException) circumvents the ignoreExceptions >> settings on appenders. >> > > If wonder if we should change the org.apache.logging.log4j.spi. > AbstractLogger.tryLogMessage(String, Level, Marker, Message, Throwable) > -- a new method called from logMessageSafely -- such that if an > AppenderLoggingException is thrown it is always surfaced. > > The lower guts would only throw AppenderLoggingException as allowed by > ignoreExceptions. AppenderLoggingException should not be throws in the guts > of appenders, let IOExceptions and other trickle up and be handled per > ignoreExceptions. > > Thoughts? > > Gary > > > >> * "Fix broken JmsServer in log4j-server": I'm not that but that's how I >> discovered the above. >> >> * "Prepare release of logging-log4j-tools repo (if we want to do that)": >> For my buck, I'd prefer to see the log4j-server module in the main repo. >> >> Gary >> >> On Sun, Jul 30, 2017 at 12:51 PM, Mikael Ståldal <[email protected]> >> wrote: >> >>> * Ensure that Scala API documentation will be present on Log4j website. >>> >>> * Fix broken JmsServer in log4j-server. >>> >>> * Prepare release of logging-log4j-tools repo (if we want to do that). >>> >>> Anything else? >>> >>> >> >
