[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117642#comment-16117642 ]
ASF GitHub Bot commented on LOG4J2-1997: ---------------------------------------- Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797360 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeSynchronousLoggingTest.java --- @@ -32,6 +32,7 @@ public void testNoAllocationDuringSteadyStateLogging() throws Throwable { /** * This code runs in a separate process, instrumented with the Google Allocation Instrumenter. + * First is the above spelled correctly, secondly where is the import then? (KM) --- End diff -- Why is this in the patch? It should be a question on the dev list. > Test classes do not close resources and use deprecated methods > -------------------------------------------------------------- > > Key: LOG4J2-1997 > URL: https://issues.apache.org/jira/browse/LOG4J2-1997 > Project: Log4j 2 > Issue Type: Bug > Components: Core > Affects Versions: 2.9 > Environment: Ubuntu Linux 16.04.2 x64 > Oracle Java 8 with Hotspot > Reporter: kenneth mcfarland > Fix For: 2.9 > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Some of the test classes are not closing resources and / or using deprecated > methods. I have modified a number of files to keep the test cases looking > clean. -- This message was sent by Atlassian JIRA (v6.4.14#64029)