Did you even look at the style guide before going through with this? http://logging.apache.org/log4j/2.x/javastyle.html
We use a code formatter, too, which gets you most of the way there. If you want to help fix up style issues, contributing a better checkstyle configuration and fixing the errors would be more useful IMO. And I think you should really take a look through the code of conduct: http://apache.org/foundation/policies/conduct.html On 7 August 2017 at 22:20, kenneth mcfarland <kennethpmcfarl...@gmail.com> wrote: > The comment " this would look so cool using lambdas " is in my opinion > childish. > > I did not know the order of static imports was incorrect, I'm used to > seeing them at top almost every other project but a simple copy paste is > fine. Even the Oracle examples do it but I really don't think it's worth > analyzing, I'll change it. > > Other capitalization fixes were made, so logs to console had consistent > casing, again based off the majority of existing classes and the test class > itself. > > The other comments simply add a more robust output. > > Respectful yours, > Kenneth > > > > On Aug 7, 2017 5:49 PM, "rgoers" <g...@git.apache.org> wrote: > > > Github user rgoers commented on a diff in the pull request: > > > > https://github.com/apache/logging-log4j2/pull/106# > > discussion_r131797894 > > > > --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/ > LogEventFactoryTest.java > > --- > > @@ -87,7 +88,7 @@ public void before() { > > @Test > > public void testEvent() { > > final org.apache.logging.log4j.Logger logger = > > context.getLogger("org.apache.test.LogEventFactory"); > > - logger.error("error message"); > > + logger.error("Error message"); > > --- End diff -- > > > > Why does this message need to be changed? > > > > > > --- > > If your project is set up for it, you can reply to this email and have > your > > reply appear on GitHub as well. If your project does not have this > feature > > enabled and wishes so, or if the feature is enabled but not working, > please > > contact infrastructure at infrastruct...@apache.org or file a JIRA > ticket > > with INFRA. > > --- > > > -- Matt Sicker <boa...@gmail.com>
