On Mon, Feb 4, 2019 at 9:30 AM Ralph Goers <ralph.go...@dslextreme.com> wrote:
> Umm, what do you mean by “deal with the removal of > sun.reflect.Reflection”? AFAIK that has already been dealt with. > Two items: (1) Building on top of Java 11 gives you an error: (2) Building on Java 8 (mvn clean install) and then running tests on Java 11 (mvn test) gives errors: [ERROR] Failures: [ERROR] StackLocatorUtilTest.testGetCallerClass:49 expected same:<class org.apache.logging.log4j.util.StackLocatorUtilTest> was not:<null> [ERROR] StackLocatorUtilTest.testGetCallerClassViaAnchorClass:89 expected same:<class org.junit.runners.BlockJUnit4ClassRunner> was not:<class java.lang.Object> [ERROR] StackLocatorUtilTest.testGetCallerClassViaName:80 expected same:<class org.junit.runners.BlockJUnit4ClassRunner> was not:<null> [ERROR] StackLocatorUtilTest.testLocateClass:97 Incorrect class expected:<class org.apache.logging.log4j.util.StackLocatorUtilTest> but was:<class java.lang.Object> [ERROR] Errors: [ERROR] LogManagerTest.testGetLogger:53 » UnsupportedOperation No class provided, and ... [ERROR] LogManagerTest.testGetLoggerForAnonymousInnerClass1:81 » UnsupportedOperation ... [ERROR] LogManagerTest.testGetLoggerForInner:109 » UnsupportedOperation No class provi... [ERROR] LogManagerTest.testGetLoggerForStaticInner:119 ExceptionInInitializer [ERROR] LoggerTest.getFormatterLogger:231 » UnsupportedOperation No class provided, an... [ERROR] LoggerTest.getLoggerByNullClass:413 » UnsupportedOperation No class provided, ... [ERROR] LoggerTest.getLoggerByNullObject:419 » UnsupportedOperation No class provided,... [ERROR] LoggerTest.getLoggerByNullString:425 » UnsupportedOperation No class provided,... [ERROR] StackLocatorUtilTest.testStackTraceEquivalence:36 NoClassDefFound sun/reflect/... [INFO] [ERROR] Tests run: 638, Failures: 4, Errors: 9, Skipped: 3 My tool chain looks like this: Gary > > Ralph > > > On Feb 4, 2019, at 7:14 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > > > > +1 > > > > Tested with the RC tag > > - Apache RAT check OK > > - Apache CLIRR check OK on the log4j-api module > > - Builds OK with 'mvn -V clean install': > > > > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > > 2018-10-24T14:41:47-04:00) > > Maven home: C:\Java\apache-maven-3.6.0\bin\.. > > Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: C:\Program > > Files\Java\jdk1.8.0_202\jre > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > > > Not sure this matters on Java 9: > > > > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > > 2018-10-24T14:41:47-04:00) > > Maven home: C:\Java\apache-maven-3.6.0\bin\.. > > Java version: 9.0.4, vendor: Oracle Corporation, runtime: C:\Program > > Files\Java\jdk-9.0.4 > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > > > [INFO] --- maven-assembly-plugin:3.1.0:single (zip) @ log4j-core-java9 > --- > > [INFO] Reading assembly descriptor: src/assembly/java9.xml > > [ERROR] OS=Windows and the assembly descriptor contains a *nix-specific > > root-relative-reference (starting with slash) > /classes/META-INF/versions/9 > > [ERROR] OS=Windows and the assembly descriptor contains a *nix-specific > > root-relative-reference (starting with slash) /classes > > [INFO] Building zip: > > > C:\temp\rc\logging-log4j2\log4j-core-java9\target\log4j-core-java9-2.11.2.zip > > > > and: > > > > [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: > > 0.56 s <<< FAILURE! - in > > > org.apache.logging.log4j.core.appender.MemoryMappedFileAppenderLocationTest > > [ERROR] > > > testMemMapLocation(org.apache.logging.log4j.core.appender.MemoryMappedFileAppenderLocationTest) > > Time elapsed: 0.558 s <<< FAILURE! > > java.lang.AssertionError: Shrunk to actual used size expected:<478> but > > was:<32768> > > at > > > org.apache.logging.log4j.core.appender.MemoryMappedFileAppenderLocationTest.testMemMapLocation(MemoryMappedFileAppenderLocationTest.java:75) > > > > Is this a real error or a problem in the test itself? > > > > I've never used this appender and I do not need it but I need other fixes > > in this release urgently for Java 8, so I am still +1. > > > > Build and tests fail with Java 11, a nice to do for 2.12.0 IMO, we might > > need a log4j-core-java11 module to deal with the removal of > > sun.reflect.Reflection. > > > > Gary > > > > On Sun, Feb 3, 2019 at 7:04 PM Ralph Goers <ralph.go...@dslextreme.com> > > wrote: > > > >> This is a vote to release Log4j 2.11.2, the next version of the Log4j 2 > >> project. > >> > >> Please download, test, and cast your votes on the log4j developers list. > >> [] +1, release the artifacts > >> [] -1, don't release because... > >> > >> The vote will remain open for 72 hours (or more if required). All votes > >> are welcome and we encourage everyone to test the release, but only > Logging > >> PMC votes are “officially” counted. As always, at least 3 +1 votes and > more > >> positive than negative votes are required. > >> > >> Changes in this release include: > >> > >> New Features > >> > >> • LOG4J2-2496: JDBC Appender should reconnect to the database > when > >> a connection goes stale. > >> • LOG4J2-2505: Let JDBC PoolingDriverConnectionSource with Apache > >> Commons DBCP configure a PoolableConnectionFactory. > >> • LOG4J2-2509: Allow a JDBC Appender to truncate strings to match > >> a table's metadata column length limit. > >> • LOG4J2-1246: PatternLayout %date conversion pattern should > >> render time zone designator for ISO-ISO8601. > >> Fixed Bugs > >> > >> • LOG4J2-2543: Add Log4j-to-SLF4J to BOM pom.xml. Thanks to > Dermot > >> Hardy. > >> • LOG4J2-2061: Use the file pattern as the FileManager "name" > when > >> no filename is present. > >> • LOG4J2-2009: Expose LoggerContext.setConfiguration as a public > >> method. > >> • LOG4J2-2542: CronTriggeringPolicy was not rolling properly, > >> especially when used with the SizeBasedTriggeringPolicy. > >> • LOG4J2-2266: Load PropertySources from any accessible > >> ClassLoader. Hide any exceptions that may occur accessing a > PropertySource. > >> • LOG4J2-1570: Logging with a lambda expression with a method > call > >> that also logs would cause logs within method call to reference line num > >> and method name of the parent method. > >> • LOG4J2-2485: SizeBasedTriggeringPolicy was not honored when > >> using the DirectWriteRolloverStrategy if the machine restarts. Thanks to > >> Giovanni Matteo Fumarola. > >> • LOG4J2-1906: Direct write was creating files with the wrong > >> date/time. > >> • LOG4J2-2453: Add Log4j-slf4j18-impl dependency to bom pom. > >> Thanks to theit. > >> • LOG4J2-2515: Configuration documentation referenced incorrect > >> method name. Thanks to MakarovS. > >> • LOG4J2-2514: Make Strings.toRootUpperCase a static method so it > >> can be accessed. Thanks to smilebrian0515. > >> • LOG4J2-1571: Fixed Appenders section in Extending Log4j. Thanks > >> to torbenmoeller. > >> • LOG4J2-2397: Predeployment of PersistenceUnit that using Log4j > >> as session logger failed (#198). Thanks to EckelDong. > >> • LOG4J2-2365: NameAbbreviator correctly abbreviates first > >> fragments (#188). Thanks to Eugene Zimichev. > >> • LOG4J2-2201: Fix memory leak in ReusableParameterizedMessage. > >> • LOG4J2-2363: ReusableObjectMessage parameter is properly passed > >> to appenders (#203). Thanks to Brian Laub. > >> • LOG4J2-2418: NullPointerException when closing never used > >> RollingRandomAccessFileAppender. Thanks to Jonas Rutishauser. > >> • LOG4J2-2422: Handle some unchecked exceptions while loading > >> plugins. Thanks to rswart, Gary Gregory. > >> • LOG4J2-2441: Setting a null ErrorHandler on AbstractAppender is > >> not allowed and will no-op as expected. > >> • LOG4J2-2444: ErrorHandler is invoked with a LogEvent and > >> Throwable when possible, where previously only a string was used. > >> • LOG4J2-2413: Exceptions are added to all columns when a JDBC > >> Appender's ColumnMapping uses a Pattern. Thanks to Andres Luuk, Gary > >> Gregory. > >> • LOG4J2-2466: ColumnMapping literal not working. Thanks to Paolo > >> Bonanomi, Gary Gregory. > >> • LOG4J2-2478: AbstractStringLayoutStringEncodingBenchmark > returns > >> the computed variables on each benchmark to avoid DCE. Thanks to Diego > >> Elias Costa. > >> • LOG4J2-2134: StackOverflowError at > >> AwaitCompletionReliabilityStrategy. Thanks to David del Amo Mateos, Gary > >> Gregory. > >> • LOG4J2-2481: Avoid NullPointerExceptions in > >> org.apache.logging.log4j.core.config.AbstractConfiguration for null > >> arguments. > >> • LOG4J2-2457: RollingRandomAccessFileManager ignores new file > >> patterns from programmatic reconfiguration. Thanks to Heiko Schwanke, > Gary > >> Gregory. > >> • LOG4J2-2482: BasicContextSelector cannot be used in a OSGI > >> application. Thanks to Rob Gansevles. > >> • LOG4J2-2476: org.apache.log4j.SimpleLayout and ConsoleAppender > >> missing in log4j-1.2-api. Thanks to Al Bundy. > >> • LOG4J2-2497: JmsAppender reconnectIntervalMillis cannot be set > >> from a configuration file. > >> • LOG4J2-2499: JMS Appender may throw a NullPointerException when > >> JMS is not up while the Appender is starting. > >> • LOG4J2-2508: JDBC Appender fails when using both parameter, > >> source, and literal ColumnMapping elements. > >> • LOG4J2-2527: Prevent ConcurrentModificationException while > >> iterating over ListAppender events. > >> • LOG4J2-2522: Fix regression using MapMessageLookup.lookup with > >> MapMessages that do not implement StringMapMessage. Thanks to Adam > Lesiak. > >> • LOG4J2-2530: Generalize checks using MapMessage implementations > >> with do not extend StringMapMessage. Introduce new JAVA_UNQUOTED > MapMessage > >> format type based on the JAVA formatting, but without quoted values. > Thanks > >> to Travis Spencer. > >> • LOG4J2-2533: Fix a regression introduced by LOG4J2-2301 in > >> 2.11.1 allowing allocation to occur in AsyncLoggerConfig. Thanks to > Michail > >> Prusakov. > >> Changes > >> > >> • LOG4J2-1576: Switch from CLIRR to RevAPI for detecting API > >> changes. > >> • LOG4J2-2391: Improve exception logging performance. > >> ThrowableProxy construction uses a more faster method to discover the > >> current stack trace. ThrowablePatternConverter and > >> ExtendedThrowablePatternConverter default configurations no longer > allocate > >> an additional buffer for stack trace contents. > >> • LOG4J2-2447: Let the NullAppender default its name to "null". > >> • LOG4J2-2468: Update Jackson from 2.9.6 to 2.9.7. > >> • LOG4J2-2469: Update Apache Commons Compress from 1.17 to 1.18. > >> • LOG4J2-2470: Update Apache Commons CSV from 1.5 to 1.6. > >> • LOG4J2-2471: Update javax.mail from 1.6.1 to 1.6.2. > >> • LOG4J2-2472: Update mongo-java-driver 3 from 3.8.0 to 3.8.2. > >> • LOG4J2-2489: JDBC Appender should release parameter resources > >> ASAP. > >> • LOG4J2-2491: Allow all Appenders to optionally carry a Property > >> array. > >> • LOG4J2-2405: Better handling of %highlight pattern when using > >> jul-bridge. Thanks to Marco Herrn. > >> • LOG4J2-2503: Update MongoDB driver from 3.8.2 to 3.9.0 for > >> log4j-mongodb3 module. > >> > >> Tag: > >> a) for a new copy do "git clone > >> https://github.com/apache/logging-log4j2.git"; and then "git checkout > >> tags/log4j-2.11.2-rc1” > >> b) for an existing working copy to “git pull” and then “git checkout > >> tags/log4j-2.11.2-rc1” > >> > >> Web Site: http://rgoers.github.io/log4j2-site/index.html. > >> > >> Maven Artifacts: > >> > https://repository.apache.org/content/repositories/orgapachelogging-1042/ > >> > >> Distribution archives: > >> https://dist.apache.org/repos/dist/dev/logging/log4j/ > >> > >> You may download all the Maven artifacts by executing: > >> wget -e robots=off --cut-dirs=7 -nH -r -p -np --no-check-certificate > >> > https://repository.apache.org/content/repositories/orgapachelogging-1042/org/apache/logging/log4j/ > >> > >> Ralph > >> > > >
