On Fri, Jan 17, 2020 at 10:01 AM Gary Gregory <[email protected]> wrote:
> Does this help: https://logging.apache.org/log4j/2.x/manual/layouts.html > But basically you cannot collapse the 2 since you want to be able to pretty- vs. compact-print AND you want to terminate the whole thing with an optional NUL. Gary > Gary > > On Fri, Jan 17, 2020 at 8:44 AM Volkan Yazıcı <[email protected]> > wrote: > >> Gary, would you mind explaining the interaction between the following >> fields, please? >> >> boolean eventEol (What does this denote?) >> String endOfLine >> boolean compact >> String eol >> boolean includeNullDelimiter >> >> At first, I thought "compact" is just used to enable pretty-printing, >> but then I encountered the following one-line ternary teaser: >> >> this.eol = endOfLine != null ? endOfLine : compact && !eventEol ? >> COMPACT_EOL : DEFAULT_EOL; >> >> I will appreciate some hints here. >> >> (Sorry for spamming the list. Is there a FreeNode channel or sth >> similar where I can direct my questions to?) >> >> On Fri, Jan 17, 2020 at 2:33 PM Gary Gregory <[email protected]> >> wrote: >> > >> > On Fri, Jan 17, 2020 at 8:16 AM Ralph Goers <[email protected] >> > >> > wrote: >> > >> > > Makes sense to me. >> > > >> > >> > Not to me ;-) >> > >> > The optional NULL is to end an event. An EOL is to end a line when you >> are >> > not using a compact format. >> > >> > Gary >> > >> > > >> > > Ralph >> > > >> > > > On Jan 17, 2020, at 6:11 AM, Volkan Yazıcı <[email protected] >> > >> > > wrote: >> > > > >> > > > Jackson layouts accept the following two parameters: >> > > > >> > > > String eol >> > > > boolean includeNullDelimiter >> > > > >> > > > Their purpose is simple: >> > > > >> > > > logEvent(event); >> > > > writer.write(eol); >> > > > if (includeNullDelimiter) { >> > > > writer.write('\0'); >> > > > } >> > > > >> > > > Isn't it possible to combine this into a single "String eol"? That >> is, >> > > > >> > > > <eol>\r\n\0</eol> >> > > > >> > > > Wouldn't this eliminate the need for the 2nd flag? I guess I cannot >> > > > see the big picture. Any ideas? >> > > > >> > > >> > > >> > > >> >
