As a bonus, your PR is complex enough that I may end up being able to showcase how the redone dependency injection system I've been working on can simplify things in 3.x. Everything is organized nicely for it!
On Tue, 28 Jan 2020 at 16:40, Matt Sicker <[email protected]> wrote: > > I've started browsing through your PR. It's given me a tangential > question that I didn't feel like leaving on the PR: I see the > continued use of our FastDateTime classes from Commons, and now I'm > wondering if we still need to use this in Java 8? Could be worth > exploring. > > I also noted some clarifications on how plugin dependency injection > currently works so you can simplify some of your wrappers if desired. > > On Tue, 28 Jan 2020 at 13:59, Volkan Yazıcı <[email protected]> wrote: > > > > I've just created a PR[1] contributing LogstashLayout to Log4j core. > > Please see the GitHub link for the feedback/support requests. I will > > appreciate a quick review cycle, since I will try my best to invest > > quite some time into this during FOSDEM. > > > > [1] https://github.com/apache/logging-log4j2/pull/335 > > > > -- > Matt Sicker <[email protected]> -- Matt Sicker <[email protected]>
