Hey Ralph, Thanks so much for taking time, really appreciated. Unfortunately the last few days I was pretty busy both at home and at work. I will check out your changes and reply back as soon as I find some time.
Kind regards. On Wed, Jul 8, 2020 at 1:08 AM Ralph Goers <ralph.go...@dslextreme.com> wrote: > > Volkan, > > I have updated the relevant documentation. I am done with all the changes I > wanted to make. > > Ralph > > > On Jul 6, 2020, at 2:50 PM, Ralph Goers <ralph.go...@dslextreme.com> wrote: > > > > I have fixed the issue with the annotations. I have added the ability to > > format the message field using a pattern and I have modified the code so > > that specifying eventDelimiter=“null” will insert a null at the end of the > > message as specifying eventDelimiter=“\0” or “\u000” does not work (It ends > > up being “\\0” or “\u000”. > > > > I have verified that with these changes the message is formatted properly > > with Gelf. I am still testing though to see how the ThreadContext is being > > handled. > > > > Ralph > > > >> On Jul 5, 2020, at 11:01 PM, Ralph Goers <ralph.go...@dslextreme.com> > >> wrote: > >> > >> I finally got some time to start testing JsonTemplateLayout against the > >> logging in the cloud documentation. The first problem I ran into is that > >> additional fields don’t work. I don’t see any configurations that have > >> them and the Builder doesn’t have annotations on the key and value fields > >> so I suspect it just doesn’t work. Why didn’t you just enhance > >> KeyValuePair to add the type attribute? > >> > >> After I corrected the EventTemplateAdditionalField plugin I still can’t > >> get stack traces the way I want them. I thought you said you added the > >> ability to format the message using a pattern, but I don’t see that in the > >> documentation or in MessageResolver. Was that not included? As I said, I > >> require the stack trace to print in the message field in Kibana, not just > >> be a key in the additional data. > >> > >> > >> Ralph > >> > > > > > > > >
