You’re too kind, you did all the work! This is what open source development is all about!
Carter > On Jan 9, 2021, at 10:01 AM, Volkan Yazıcı <volkan.yaz...@gmail.com> wrote: > > After incorporating changes requested by Carter and Gary, I have merged > this branch. > > I want to take this opportunity to thank Carter for his great patience, > kind help, and terrific assistance! > >> On Thu, Jan 7, 2021 at 12:12 PM Volkan Yazıcı <volkan.yaz...@gmail.com> >> wrote: >> >> Hello, >> >> Carter and I have spent some time on overhauling the AsyncAppender >> background thread. The last state of the changes are available in the >> GitHub PR <https://github.com/apache/logging-log4j2/pull/452>. In a >> nutshell, the incorporated changes are as follows: >> >> >> - AppenderControl catch clauses is demoted from Throwable to Exception. >> (Aligned with the pre-2.14.0 behaviour.) >> - AsyncAppender.AsyncThread is moved to AsyncAppenderEventForwarder with >> plenty of refactoring for simplification. >> - On shutdown, AsyncAppenderEventForwarder forwards all the remaining >> LogEvents, whereas AsyncAppender.AsyncThread was ignoring non- >> Log4LogEvents. >> - AsyncAppenderExceptionHandlingTest is improved for ThreadDeath. >> >> >> I would appreciate it if somebody can review the work. I want to get this >> in, fix any broken tests (if necessary), and make a new release. >> >> Kind regards. >> >>
