Thanks for reviewing the PR, Ron. Indeed that is a typo, I have fixed it. I will merge the branch.
Regarding your work on PatternLayout, I will check it momentarily and share my feedback there. About the syntax compliance between multiple layouts... I don't think it is necessary. For one, JsonTemplateLayout and PatternLayout are already pretty distinct in terms of naming conventions. Second, PatternLayout strives to keep names short since it preferably needs to fit in a line and still be human readable, whereas JsonTemplateLayout has no such concerns, since the template is already structured as JSON, hence there I strive to make names as self-descriptive as possible without getting concerned too much about their length. On Mon, Jan 18, 2021 at 1:04 AM Ron Grabowski <[email protected]> wrote: > Yes, this is the intent of LOG4J2-2986: > > "stackTrace": { > "stringified": true, > "truncatedStringSuffix": ">", > "truncationPointStrings": ["at javax.servlet.http.HttpServlet.service"] > } > > That snippet from the PR doesn't seem to match your documentation grammar > "truncationPointStrings" > vs "truncationPointMatcherStrings": > > stringified = "stringified" -> boolean > truncatedStringSuffix = "truncatedStringSuffix" -> string > truncationPointMatcherStrings = "truncationPointMatcherStrings" -> string[] > truncationPointMatcherRegexes = "truncationPointMatcherRegexes" -> string[] > > I just finished up with a PR on my ticket too. Since I'm dealing with > frames I decided to build on the existing "filters" name for packages and > name it "filters.startFrames": > > filters.startFrames(javax.servlet.http.HttpServlet.service) > > I don't support regexes (yet?) > > Do you think the name/syntax should match across features or is the Json > layout unique enough that having two names (truncationPoint*, startFrames) > for the same concept is ok? > > On Friday, January 15, 2021, 10:59:26 AM EST, Volkan Yazıcı < > [email protected]> wrote: > > > Hello, > > I have cloned Ron's LOG4J2-2986 > <https://issues.apache.org/jira/browse/LOG4J2-2986> (truncation of stack > traces after a matching point) for JSON template layout in LOG4J2-2993 > <https://issues.apache.org/jira/browse/LOG4J2-2993> and created a PR > <https://github.com/apache/logging-log4j2/pull/458>. I would appreciate > it if somebody can review the changes, in particular, how matching against > the provided regexes are performed via grouping. > > @Ron, I will appreciate it if you can confirm that the implemented feature > set is indeed what you were asking for. > > Kind regards. > > *P.S.* @Remko Popma <[email protected]>, I still cannot add you as a > reviewer to GitHub PRs. >
