Sounds good. I'll update that in the coming days/weeks - I have a deadline approaching for work, so I may not be able to do much for a bit.
I'll also assume that other C++11 features are available(e.g. std::thread, enhanced for loop) moving forward. -Robert Middleton On Tue, Mar 2, 2021 at 9:06 AM Thorsten Schöning <tschoen...@am-soft.de> wrote: > > Guten Tag Robert Middleton, > am Samstag, 27. Februar 2021 um 17:22 schrieben Sie: > > > As for removing them completely, it depends on what we want to do. > > Personally, I don't like typedefs too much[...] > > I'm the opposite and prefer "log4cxx::LoggerPtr" in general, as in > most cases I don't need to care about the underlying type. > > > Removing the typedefs would break a lot of existing code that depends > > on LoggerPtr though, so I would be fine just typedef-ing the pointers > > with the macros that we have now, but permanently typedef-ing to > > std::shared_ptr(no utilization of boost fallback behavior). > > We are talking about two different things: Yes, let's only use > std::shared_ptr without BOOST. I suggest to not rebase your PR but > keep individual commits with those changes instead to document the > decision and get access to the them if necessary at some point. > > The other aspect you are mentioning is that some code is using > typedefs directly and some is using the macros. So, should the former > be changed as well? > > > class LoggingEvent; > > typedef std::shared_ptr<LoggingEvent> LoggingEventPtr; > > to? > > > class LoggingEvent; > > LOG4CXX_PTR_DEF(LoggingEvent); > > Or leave it as is? In the long term LOG4CXX_PTR_DEF could be replaced > entirely as well. > > OTOH: > > > #define LOG4CXX_PTR_DEF(T) typedef log4cxx::shared_ptr<T> T##Ptr;\ > > typedef log4cxx::weak_ptr<T> T##WeakPtr > > to > > > #define LOG4CXX_PTR_DEF(T) typedef std::shared_ptr<T> T##Ptr;\ > > typedef std::weak_ptr<T> T##WeakPtr > > Because of not using BOOST-fallbacks anymore, additionally removing > the CMAKE-based checks. > > Mit freundlichen Grüßen > > Thorsten Schöning > > -- > AM-SoFT IT-Service - Bitstore Hameln GmbH i.G. > Mitglied der Bitstore Gruppe - Ihr Full-Service-Dienstleister für IT und TK > > E-Mail: thorsten.schoen...@am-soft.de > Web: http://www.AM-SoFT.de/ > > Tel: 05151- 9468- 0 > Tel: 05151- 9468-55 > Fax: 05151- 9468-88 > Mobil: 0178-8 9468-04 > > AM-SoFT IT-Service - Bitstore Hameln GmbH i.G., Brandenburger Str. 7c, 31789 > Hameln > AG Hannover HRB neu - Geschäftsführer: Janine Galonska > > > Für Rückfragen stehe ich Ihnen sehr gerne zur Verfügung. > > Mit freundlichen Grüßen > > Thorsten Schöning > > > Tel: 05151 9468 0 > Fax: 05151 9468 88 > Mobil: > Webseite: https://www.am-soft.de > > AM-Soft IT-Service - Bitstore Hameln GmbH i.G. ist ein Mitglied der Bitstore > Gruppe - Ihr Full-Service-Dienstleister für IT und TK > > AM-Soft IT-Service - Bitstore Hameln GmbH i.G. > Brandenburger Str. 7c > 31789 Hameln > Tel: 05151 9468 0 > > Bitstore IT-Consulting GmbH > Zentrale - Berlin Lichtenberg > Frankfurter Allee 285 > 10317 Berlin > Tel: 030 453 087 80 > > CBS IT-Service - Bitstore Kaulsdorf UG > Tel: 030 453 087 880 1 > > Büro Dallgow-Döberitz > Tel: 03322 507 020 > > Büro Kloster Lehnin > Tel: 033207 566 530 > > PCE IT-Service - Bitstore Darmstadt UG > Darmstadt > Tel: 06151 392 973 0 > > Büro Neuruppin > Tel: 033932 606 090 > > ACI EDV Systemhaus Dresden GmbH > Dresden > Tel: 0351 254 410 > > Das Systemhaus - Bitstore Magdeburg GmbH > Magdeburg > Tel: 0391 636 651 0 > > Allerdata.IT - Bitstore Wittenberg GmbH > Wittenberg > Tel: 03491 876 735 7 > > Büro Liebenwalde > Tel: 033054 810 00 > > HSA - das Büro - Bitstore Altenburg UG > Altenburg > Tel: 0344 784 390 97 > > Bitstore IT – Consulting GmbH > NL Piesteritz > Piesteritz > Tel: 03491 644 868 6 > > Solltec IT-Services - Bitstore Braunschweig UG > Braunschweig > Tel: 0531 206 068 0 > > MF Computer Service - Bitstore Gütersloh GmbH > Gütersloh > Tel: 05245 920 809 3 > > Firmensitz: AM-Soft IT-Service - Bitstore Hameln GmbH i.G. , Brandenburger > Str. 7c , 31789 Hameln > Geschäftsführer Janine Galonska > > > > > >
