If you're able to test the PR that I just did, that would be helpful:
https://github.com/apache/logging-log4cxx/pull/63

All of the tests pass so it's probably good, but an extra set of eyes
is helpful.

-Robert Middleton

On Thu, Apr 15, 2021 at 4:32 AM Stephen Webb <swebb2...@gmail.com> wrote:
>
> > Or maybe we just need something like LOG4CXX_SOURCE_DIR?
>
> yes, I like that idea - something we control.
>
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
> Virus-free.
> www.avast.com
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>
> On Thu, Apr 15, 2021 at 11:28 AM Robert Middleton <
> robert.middle...@rm5248.com> wrote:
>
> > > Using  ${CMAKE_SOURCE_DIR}  instead of a relative path creates a problem
> > > when including the log4cxx root directory from a higher level
> > > CMakeLists.txt. CMAKE_SOURCE_DIR is (inconveniently) set where the
> > top-most
> > > CMakeLists.txt file resides.
> > >
> > > You are using ${CMAKE_SOURCE_DIR}  in src/main /include and src/main/cpp.
> >
> > Apparently also in the Doxyfile.in as well - do you know what the
> > correct variable should be?  It looks like we may want to use
> > PROJECT_SOURCE_DIR instead, if we can't do absolute paths.  Or maybe
> > we just need something like LOG4CXX_SOURCE_DIR?
> >
> > -Robert Middleton
> >

Reply via email to