Hello Volkan, Ralph Please let me mention that the transformer is quite tiny (3 java classes) extension for the existing Maven Shade Plugin <https://maven.apache.org/plugins/maven-shade-plugin/> therefore I would suggest *Artifact ID:* shade-plugin-log4j-transformer
Regarding the class name please take into account the existing transformer implementations org.apache.maven.plugins.shade.resource.AppendingTransformer org.apache.maven.plugins.shade.resource.XmlAppendingTransformer org.apache.maven.plugins.shade.resource.properties.PropertiesTransformer It's good to determine the full class name, for example - *Transformer class name:* org.apache.logging.maven.plugins.shade.Log4j2PluginCacheFileTransformer Also I hope it's not hard to create new project with all related infrastructure -- Best regards, Ed maven-log4j-shade-plugin-transformer' - *GitHub project name:* logging-log4j2-maven-plugins - *Group ID:* org.apache.logging.maven - *Artifact ID:* maven-log4j-shade-plugin-transformer (in a submodule, and note the `maven-*-plugin` convention for unofficial Maven plugins) - *Transformer class name:* Log4jPluginCacheFileCombiner On Fri, Oct 15, 2021 at 5:27 PM Volkan Yazıcı <[email protected]> wrote: > I also support the idea of moving it to a separate project. > `logging-log4j2` is already bloated a lot and it hurts compilation & test > times, severely. > I think we have already agreed on breaking up the project into individual > projects. > My proposal: > > - *GitHub project name:* logging-log4j2-maven-plugins > - *Group ID:* org.apache.logging.maven > - *Artifact ID:* maven-log4j-transformer-plugin (in a submodule, and > note the `maven-*-plugin` convention for unofficial Maven plugins) > - *Transformer class name:* Log4jPluginCacheFileCombiner > > > > On Fri, Oct 15, 2021 at 4:04 PM Apache <[email protected]> wrote: > > > Question: Do we want it as a sub-module or as a new git repo with its own > > release? > > > > Ralph > > > > > On Oct 15, 2021, at 6:50 AM, Eduard Gizatullin <[email protected]> > wrote: > > > > > > Hello dear log4j team > > > > > > Volkan Yazıcı asked me to make maven-shaded-log4j-transformer > > > <https://github.com/edwgiz/maven-shaded-log4j-transformer> a part of > > > log4j2 and I tend to accomplish the proposal. > > > > > > Can you please confirm that > > > new sub-module name log4j-maven-shade-plugin is ok > > > > > > Any preliminary advice will be appreciated > > > > > > > > > -- > > > Best regards, > > > Ed > > > > > > > > >> On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı <[email protected]> wrote: > > >> > > >> Thanks for the prompt (and positive!) reply Eduard! > > >> I think it is best to first lay out the details of the plan in a post > > to the > > >> dev mailing list < > https://logging.apache.org/log4j/2.x/mail-lists.html > > >. > > >> For instance, the module name, transformer name, documentation > changes, > > >> etc. > > >> This will give others an opportunity to share their feedback and > > remarks. > > >> Then simply create a JIRA < > > https://issues.apache.org/jira/projects/LOG4J2> > > >> ticket and submit a GitHub <https://github.com/apache/logging-log4j2> > > PR. > > >> > > >> `master` branch targets Log4j 3, which is not released yet. > > >> It uses a different plugin loading mechanism than the one used in > Log4j > > 2. > > >> Log4j 3 doesn't suffer from this "override of plugins after shading" > > >> problem. > > >> Hence, the PR needs to target the `release-2.x` branch. > > >> > > >> Also note that since this is a non-trivial contribution, you need to > > sign the > > >> ICLA document <https://www.apache.org/licenses/icla.pdf> and email it > > to > > >> the ASF <[email protected]>. > > >> Once you have done this, it is good to mention this in the dev mailing > > >> list. > > >> > > >> On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin <[email protected]> > > >> wrote: > > >> > > >>> Hello Volkan, > > >>> > > >>> Thank you for letting me know, I'm all for it. > > >>> > > >>> Couldn't you please confirm that target branch is master > > >>> and log4j-maven-plugins is ok as new name of submodule > > >>> > > >>> Any other advices will be appreciated, > > >>> > > >>> -- > > >>> Best regards, > > >>> Ed > > >>> > > >>> > > >>>> On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı <[email protected]> > > wrote: > > >>> > > >>>> Hello, > > >>>> > > >>>> My name is Volkan Yazici and I am a PMC committee member of the ASF > > >>>> Logging Services, which develops Log4j too. > > >>>> maven-shaded-log4j-transformer > > >>>> <https://github.com/edwgiz/maven-shaded-log4j-transformer> plugin > > >>>> addresses an important shortcoming of the Log4j 2.x plugin design > > surfacing > > >>>> when users want to shade it. We have recently had a chat about it in > > >>>> the mailing list > > >>>> < > > > https://lists.apache.org/thread.html/rcfa4fc8678642a51e3a69dd2b14848fe4e1e5b71de7c99a7b55ff182%40%3Cdev.logging.apache.org%3E > > >, > > >>>> and the maintainers (incl. me) are inclined to ship it as a part of > > the > > >>>> Log4j project. Would you like to contribute it yourself in the form > > of a > > >>>> GitHub PR? Note that this route is subject to update-push-review > > cycles, > > >>>> yet they are pretty rewarding for both parties, IMHO. What do you > > think? > > >>>> > > >>>> Kind regards. > > >>>> > > >>> > > > > > > >
