I agree with Remko, we should not drop look ups altogether, they are too
useful. Dropping them from parameter parsing is ok at first glance.
Gary
On Fri, Dec 10, 2021, 05:50 Remko Popma <remko.po...@gmail.com> wrote:
> I would say no. Lookups are very powerful and useful.
> We could consider removing JNDI lookups.
>
> The biggest problem however is that the lookups are applied to the logging
> message *parameters*.
> The logging message is controlled by the application, so any lookups there
> should be fine or at least any problems can be found during review/audit.
>
> I cannot imagine a scenario where doing lookups against the message
> parameters is useful.
> There could be such a scenario, but then the application should do this
> explicitly, with something like
>
> logger.info("some message {}", doExplicitLookup(param));
>
> I haven't looked at the fix in enough detail, but removing lookups in
> logging message parameters sounds reasonable.
> Not sure how easy it would be to implement this though.
>
>
> On Fri, Dec 10, 2021 at 7:31 PM Volkan Yazıcı <vol...@yazi.ci> wrote:
>
> > Shall we completely remove message lookups (which are only used by
> > PatternLayout) in master?
> >
>
