+1 `./mvnw verify` on `log4j-2.16.0-rc1` branch passes with the following setup:
$ java -version openjdk version "1.8.0_312" OpenJDK Runtime Environment (Zulu 8.58.0.13-CA-linux64) (build 1.8.0_312-b07) OpenJDK 64-Bit Server VM (Zulu 8.58.0.13-CA-linux64) (build 25.312-b07, mixed mode) $ java -version openjdk version "17.0.1" 2021-10-19 LTS OpenJDK Runtime Environment Zulu17.30+15-CA (build 17.0.1+12-LTS) OpenJDK 64-Bit Server VM Zulu17.30+15-CA (build 17.0.1+12-LTS, mixed mode, sharing) $ uname -a Linux tahta 5.11.0-41-generic #45~20.04.1-Ubuntu SMP Wed Nov 10 10:20:10 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux Though I would appreciate some small fixes, which can be incorporated later on as well: 1. index.md.vm contains references to 2.15.1 and misses Remko's improvements in LOG4J2-3214 <https://issues.apache.org/jira/browse/LOG4J2-3214> 2. security.md needs to be aligned with LOG4J2-3214 <https://issues.apache.org/jira/browse/LOG4J2-3214> too 3. appenders.xml contains references to 2.15.1 4. lookups.xml contains references to 2.15.1 5. I want a link to myself in support.md too! 6. I have encountered multiple occurrences of *"release contains one change"* phrase, yet there are actually two changes. I would rather rephrase this as *"release contains a limited set of changes focusing on security"*. 7. I have seen that CassandraAppenderIT is disabled due to aarch64 failures. I would appreciate a ticket for incorporating a @DisabledOnArch annotation. 8. In Interpolator.java, there are usages of `JndiLookup.class.getName()` and `"org.apache.logging.log4j.core.lookup.JndiLookup"`, I'd settle on one. 9. JNDI changes look good to me, great job Ralph! 10. I am baffled to see that SimplePerfTest.bubbleSort() was broken, yet tests were passing! (Thanks Matt!) I can actually incorporate website fixes. What is the procedure for that? Create a `release-2.16.0` branch derived from `log4j-2.16.0-rc1` tag and commit changes there? On Mon, Dec 13, 2021 at 9:02 AM Ralph Goers <ralph.go...@dslextreme.com> wrote: > +1 > > Verified the signature and the SHA512 hashes. Verified the build worked > for me. I did correct some mistakes in the staging site home page news > section as it still referenced 2.15.1. > > Ralph > > > > On Dec 12, 2021, at 11:18 PM, Matt Sicker <boa...@gmail.com> wrote: > > > > This is a vote to release Log4j 2.16.0, the next version of the Log4j 2 > project. > > > > Please download, test, and cast your votes on the log4j developers list. > > [] +1, release the artifacts > > [] -1, don't release because... > > > > The vote will remain open for 72 hours (or more if required). All votes > are welcome and we encourage everyone to test the release, but only Logging > PMC votes are “officially” counted. As always, at least 3 +1 votes and more > positive than negative votes are required. > > > > Changes in this release include: > > > > Fixed Bugs > > > > * LOG4J2-3208: Disable JNDI by default. Require log4j2.enableJndi to be > set to true to allow JNDI. > > * LOG4J2-3211: Completely remove support for Message Lookups. > > > > Tag: > > a) for a new copy do "git clone > https://github.com/apache/logging-log4j2.git < > https://github.com/apache/logging-log4j2.git>" and then "git checkout > tags/log4j-2.16.0-rc1” or just "git clone -b log4j-2.16.0-rc1 > https://github.com/apache/logging-log4j2.git < > https://github.com/apache/logging-log4j2.git>" > > b) for an existing working copy to “git pull” and then “git checkout > tags/log4j-2.16.0-rc1” > > > > Web Site: https://logging.staged.apache.org/log4j/2.x/index.html < > https://logging.staged.apache.org/log4j/2.x/index.html>. > > > > Maven Artifacts: > https://repository.apache.org/content/repositories/orgapachelogging-1068 < > https://repository.apache.org/content/repositories/orgapachelogging-1068> > > > > Distribution archives: > https://dist.apache.org/repos/dist/dev/logging/log4j/ < > https://dist.apache.org/repos/dist/dev/logging/log4j/> > > > > You may download all the Maven artifacts by executing: > > wget -e robots=off --cut-dirs=7 -nH -r -p -np --no-check-certificate > https://repository.apache.org/content/repositories/orgapachelogging-1068/org/apache/logging/log4j/ > > -- > > Matt Sicker > > > > >
