Thanks for the feedback. Incorporated some changes to both `master` and `release-2.x`.
On Mon, Dec 20, 2021 at 7:49 PM Dan Kegel <[email protected]> wrote: > My build procedure for the release-2.x branch succeeded on mac > 10.16.7, but is failing one lousy test on mac 11.8.1: > > > SocketAppenderReconnectTest.reconnect_should_fallback_when_there_are_multiple_resolved_hosts:129->verifyLoggingSuccess:192->awaitUntilSucceeds:219 > » ConditionTimeout > > I think > https://github.com/apache/logging-log4j2/commit/b3e8818a111d884d1fbfe > wasn't sufficient. > Going with the same timeout as on windows seemed to work, i.e. > > --- > a/log4j-core/src/test/java/org/apache/logging/log4j/core/net/SocketAppenderReconnectTest.java > +++ > b/log4j-core/src/test/java/org/apache/logging/log4j/core/net/SocketAppenderReconnectTest.java > @@ -211,7 +211,7 @@ class SocketAppenderReconnectTest { > } else { > // Universally sensible values. > pollIntervalMillis = 1000; > - timeoutSeconds = 3; > + timeoutSeconds = 15; > } > await() > .pollInterval(pollIntervalMillis, TimeUnit.MILLISECONDS) > > There's something about even nice fast corporate hex-core i7 macbooks > that is slow these days, I dunno. > - Dan >
