I'm not talking about failing tests but about some other build silliness that does not feel necessary, for example: https://github.com/apache/logging-log4j2/runs/4620228443?check_suite_focus=true
Shows: Run scacap/action-surefire-report@v1 Going to parse results form **/*-reports/TEST-*.xml Result: 4015 tests run, 15 skipped, 0 failed. Posting status 'completed' with conclusion 'success' to https://github.com/apache/logging-log4j2/pull/651 (sha: 06c61ddc60b24610fda694aa54f4c1dd2e29ff07) Error: Resource not accessible by integration Gary On Thu, Dec 23, 2021, 10:24 Volkan Yazıcı <[email protected]> wrote: > Since, there are some tests which occasionally constantly fail, we use > `-Dmaven.test.failure.ignore=true` in `verify` goal. This causes a build > with test failures to be marked green. The 3rd party component, > `scacap/action-surefire-report@v1`, is used to feed these failures back > into GitHub Actions status with some pretty printing. But since the PR is > opened by a user who doesn't have commit rights, the 3rd party component > fails to mark the failures due to insufficient privileges. In > `.github/workflows/main.yml`, I had introduced the `if: github.repository > == 'apache/logging-log4j2'` line to work around this, but apparently it is > broken again. > > I totally share your frustration, same here. Though sparing time to fix > this is pretty difficult nowadays. > > I also need to confess, in those brief moments of insanity, I contemplate > nuking all those flaky tests. This will simplify the CI magic a lot and > enhance our confidence in the tests. > > On Tue, Dec 21, 2021 at 3:10 AM Gary Gregory <[email protected]> > wrote: > > > After getting https://github.com/apache/logging-log4j2/pull/646 in what > I > > think is a good state, I have no idea if it is safe or not to merge > because > > the 1st build GitHub shows is red: > > > > > https://github.com/apache/logging-log4j2/runs/4589771553?check_suite_focus=true > > > > I don't use GH actions the way we do here and I'm not sure why we need > the > > publish test result set when anyone can just look at the build logs. > > > > Gary > > >
