+1 I checked the signature and hashes and those look good.
I unzipped the source and binaries. The appropriate license and notice files are present. I did not perform tests as I don’t have the necessary tools installed. Ralph > On Dec 23, 2021, at 1:36 PM, Matt Sicker <boa...@gmail.com> wrote: > > Root keys are in https://downloads.apache.org/logging/KEYS which is in > the dist repository where you commit releases. > > On Mon, Dec 20, 2021 at 2:03 AM Dominik Psenner <dpsen...@gmail.com> wrote: >> >> * old-log4net.snk.gpg has been the old key to sign binaries. >> * @Matt, where is the root logging KEYS file located? >> >> The changes in the release look good to me. +1 >> >> On Mon, 20 Dec 2021 at 07:34, Davyd McColl <dav...@gmail.com> wrote: >> >>> Thanks Matt >>> >>> Since you've given a +1, I'll write up some sticky notes to address these >>> points in the near future. >>> >>> -d >>> >>> >>> On December 19, 2021 23:51:45 Matt Sicker <boa...@gmail.com> wrote: >>> >>>> +1 >>>> >>>> Notes on the release: >>>> * I’ve copied your release signing key to the root logging KEYS file for >>>> easier discoverability. >>>> * The copyright year in the NOTICE file is a few years out of date at >>> this >>>> point. I’ve updated this in master, though you’ll want to update this >>> again >>>> in a couple weeks when it’s outdated again. >>>> * Some included files in the base directory of the source zip are >>> missing >>>> copyright headers or shouldn’t even be included in the tarball (e.g., >>> the >>>> appveyor config file probably isn’t necessary) >>>> - Not sure what old-log4net.snk.gpg is in there for, either. >>>> - Gulp task source files missing headers >>>> * Artifact signatures and sha512 hashes look good (checked with shasum >>>> which is the Perl script version), contain appropriate LICENSE and >>> NOTICE >>>> (besides the outdated copyright year, but not a blocker), no binaries in >>>> the source zip, appropriate files in the binary zip. >>>> >>>> -- >>>> Matt Sicker >>>> >>>>> On Dec 16, 2021, at 07:47, Davyd McColl <dav...@gmail.com> wrote: >>>>> >>>>> Hi all >>>>> >>>>> I'd like to raise a vote to release log4net 2.0.14. Changelog is up on >>> the >>>>> pre-release page at >>>>> https://github.com/apache/logging-log4net/releases/tag/rc%2F2.0.14-rc1 >>>>> >>>>> I have updated staging docs and I _think_ I've done the right thing with >>>>> respect to getting binaries and source up to the dev repo at >>>>> https://dist.apache.org/repos/dist/dev/logging, but the download links >>> on >>>>> the staging docs point to the release download area, so I'm not sure if >>> I >>>>> should rather upload there so that staging documentation "works as >>>>> expected" for the vote to continue. >>>>> >>>>> Thanks Ralph for assisting me in being able to uplodate artifacts >>> myself. >>>>> Much appreciated. >>>>> >>>>> -d >>>>> >>>>> PS. This email is a duplicate of the one sent from my work email ( >>>>> davyd.mcc...@codeo.co.za) which I believe has been lost somewhere >>> along the >>>>> way. Please ignore the other if it pops up. >>>>> >>>>> >>>>> -- >>>>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- >>>>> If you say that getting the money is the most important thing >>>>> You will spend your life completely wasting your time >>>>> You will be doing things you don't like doing >>>>> In order to go on living >>>>> That is, to go on doing things you don't like doing >>>>> >>>>> Which is stupid. >>>>> >>>>> - Alan Watts >>>>> https://www.youtube.com/watch?v=-gXTZM_uPMY >>>>> >>>>> *Quidquid latine dictum sit, altum sonatur. * >>>> >>> >> >> >> -- >> Dominik Psenner >
