I'll note that the convention from JUnit 4 is to make them public; JUnit 5 encourages package-private tests instead for some reason, and that's the default template for JUnit 5 tests in IntelliJ. I do like consistency, though!
On Wed, Jan 12, 2022 at 11:01 AM <ggreg...@apache.org> wrote: > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch release-2.x > in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git > > commit b4a892acd1d37f355c27cde10ab1736cf1ebe315 > Author: Gary Gregory <garydgreg...@gmail.com> > AuthorDate: Wed Jan 12 11:58:30 2022 -0500 > > Our convention is to make test classes public. > --- > .../test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java | 2 > +- > .../org/apache/logging/log4j/core/net/SocketAppenderReconnectTest.java | 2 > +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/log4j-core/src/test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java > > b/log4j-core/src/test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java > index df98702..5759cf7 100644 > --- > a/log4j-core/src/test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java > +++ > b/log4j-core/src/test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java > @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; > /** > * Unit tests for {@link SmtpManager}. > */ > -class SmtpManagerTest { > +public class SmtpManagerTest { > > @Test > void testCreateManagerName() { > diff --git > a/log4j-core/src/test/java/org/apache/logging/log4j/core/net/SocketAppenderReconnectTest.java > > b/log4j-core/src/test/java/org/apache/logging/log4j/core/net/SocketAppenderReconnectTest.java > index 5fa603f..87f30dd 100644 > --- > a/log4j-core/src/test/java/org/apache/logging/log4j/core/net/SocketAppenderReconnectTest.java > +++ > b/log4j-core/src/test/java/org/apache/logging/log4j/core/net/SocketAppenderReconnectTest.java > @@ -55,7 +55,7 @@ import static org.junit.jupiter.api.Assertions.*; > /** > * Tests reconnection support of {@link > org.apache.logging.log4j.core.appender.SocketAppender}. > */ > -class SocketAppenderReconnectTest { > +public class SocketAppenderReconnectTest { > > private static final Logger LOGGER = StatusLogger.getLogger(); >
