I’ll note here as I did in a related PR: this same test module separation affects log4j-plugins and log4j-core so far. Any other modules that need to define test plugins would have to do the same. — Matt Sicker
> On Apr 21, 2022, at 06:13, Remko Popma <[email protected]> wrote: > > Hi all, > I am trying to merge the changes for LOG4J2-3472 into master, but I have > trouble building the master branch... (and I don't think it is because of > my changes) > > Am I missing something? > > My environment > --------------------- > C:\Users\remko\IdeaProjects\logging-log4j2>mvn --version > Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; > 2019-08-28T00:06:16+09:00) > Maven home: C:\apps\apache-maven-3.6.2\bin\.. > Java version: 11, vendor: Oracle Corporation, runtime: C:\apps\jdk-11 > Default locale: en_GB, platform encoding: MS932 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Summary of the issue: > ----------------------------- > log4j-api/src/main compiles (with a bunch of compiler Warnings, but ok) > but log4j-api/src/test has a lot of problems though... > > First there are many (like 500 or so) warnings and then there are many > compiler errors: > > ---------------------------------------------------- > Warnings look like this: > [WARNING] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\LogManagerTest.java:[52,5] > [exports] class Test in module is not exported > [WARNING] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\LogManagerTest.java:[80,5] > [exports] class Test in module is not exported > [WARNING] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\LogManagerTest.java:[94,5] > [exports] class Test in module is not exported > ... > > All errors: > ------------------------------------------------- > [ERROR] COMPILATION ERROR : > [INFO] ------------------------------------------------------------- > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\message\MapMessageTest.java:[19,29] > error: package com.google.common.base does not exist > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\LevelTest.java:[23] > error: cannot find symbol > symbol: static assertThrowsExactly > location: class Assertions > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\junit\BundleTestInfo.java:[23,29] > error: package org.apache.maven.model does not exist > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\junit\BundleTestInfo.java:[24,37] > error: package org.apache.maven.model.io.xpp3 does not exist > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\junit\BundleTestInfo.java:[25,31] > error: package org.apache.maven.project does not exist > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\junit\BundleTestInfo.java:[26,40] > error: package org.codehaus.plexus.util.xml.pull does not exist > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\junit\BundleTestInfo.java:[33,18] > error: cannot find symbol > symbol: class MavenProject > location: class BundleTestInfo > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\util\StackLocatorUtilTest.java:[31,18] > error: package sun.reflect does not exist > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\message\MapMessageTest.java:[178,24] > error: cannot find symbol > symbol: variable Strings > location: class MapMessageTest > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\message\MapMessageTest.java:[179,24] > error: cannot find symbol > symbol: variable Strings > location: class MapMessageTest > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\LoggerTest.java:[77,14] > error: method entry in class AbstractLogger cannot be applied to given > types; > > required: String,Object[] > found: no arguments > reason: actual and formal argument lists differ in length > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\LoggerTest.java:[78,14] > error: no suitable method found for exit(no arguments) > method AbstractLogger.<R#1>exit(String,R#1) is not applicable > (cannot infer type-variable(s) R#1 > (actual and formal argument lists differ in length)) > method AbstractLogger.<R#2>exit(String,String,R#2) is not applicable > (cannot infer type-variable(s) R#2 > (actual and formal argument lists differ in length)) > where R#1,R#2 are type-variables: > R#1 extends Object declared in method <R#1>exit(String,R#1) > R#2 extends Object declared in method <R#2>exit(String,String,R#2) > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\LevelTest.java:[51,8] > error: cannot find symbol > symbol: method > assertThrowsExactly(Class<IllegalArgumentException>,()->Level.[...] 100)) > location: class LevelTest > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\LevelTest.java:[52,8] > error: cannot find symbol > symbol: method > assertThrowsExactly(Class<IllegalArgumentException>,()->Level.[...]null)) > location: class LevelTest > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\LevelTest.java:[55,8] > error: cannot find symbol > symbol: method > assertThrowsExactly(Class<IllegalArgumentException>,()->Level.[...], -1)) > location: class LevelTest > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\util\StringsTest.java:[103,33] > error: cannot find symbol > symbol: method toRootLowerCase(String) > location: class Strings > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\util\StringsTest.java:[104,33] > error: cannot find symbol > symbol: method toRootLowerCase(String) > location: class Strings > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\junit\BundleTestInfo.java:[41,18] > error: cannot find symbol > symbol: class Model > location: class BundleTestInfo > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\junit\BundleTestInfo.java:[41,36] > error: cannot find symbol > symbol: class MavenXpp3Reader > location: class BundleTestInfo > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\junit\BundleTestInfo.java:[42,31] > error: cannot find symbol > symbol: class MavenProject > location: class BundleTestInfo > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\junit\BundleTestInfo.java:[43,37] > error: cannot find symbol > symbol: class XmlPullParserException > location: class BundleTestInfo > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\util\StackLocatorUtilTest.java:[42,80] > error: cannot find symbol > symbol: variable JDK_7U25_OFFSET > location: class StackLocator > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\util\StackLocatorUtilTest.java:[42,38] > error: cannot find symbol > symbol: variable Reflection > location: class StackLocatorUtilTest > [ERROR] > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\util\ServiceLoaderUtilTest.java:[78,40] > error: method loadServices in class ServiceLoaderUtil cannot > be applied to given types; > required: Class<S>,Function<ModuleLayer,ServiceLoader<S>>,Predicate<S> > found: Class<Service>,Lookup,boolean > reason: cannot infer type-variable(s) S > (argument mismatch; Lookup cannot be converted to > Function<ModuleLayer,ServiceLoader<S>>) > where S is a type-variable: > S extends Object declared in method > <S>loadServices(Class<S>,Function<ModuleLayer,ServiceLoader<S>>,Predicate<S>)
