What are you using for Docker integration tests? I've used Testcontainers for that for the past couple years, and it usually works fine on my machine. I do have Docker, though if the images are x86-only or something, I'm not able to run those without some finagling I think. You can use assumeTrue() or similar on a check for ability to run the tests, though, so that they do run where possible (simplest approach sometimes is to just add `@DisabledIfEnvironmentVariable(named = "CI", matches = "true")` to tests that won't work in CI without further setup).
On Wed, Jun 22, 2022 at 1:57 AM Volkan Yazıcı <vol...@yazi.ci> wrote: > > Docker-dependent ITs need to be disabled by default. I forgot to copy the > skip=true snippet for maven-failsafe-plugin while merging LOG4J2-3502, > i.e., JPMS support for JTL. I have also added notes to not forget it next > time: > > Disable ITs, which are Docker-dependent, by default. > Running Docker on all expected environments (OSes, Docker-disabled CI > hosts, etc.) still needs to be worked out. > Next to that, certain container images (e.g., ELK stack) require > environment-specific limits (e.g., `nofile`). > > On Tue, Jun 21, 2022 at 6:39 PM Matt Sicker <boa...@gmail.com> wrote: > > > These tests are failing on macOS with a connection error of some sort. > > Not sure if it fails on other operating systems, but it reliably fails > > early enough in the macOS builds to cancel the others, and it fails > > for me locally as well. Possible cause could be related to JUnit > > dependency updates if there was a race condition involving finding > > available ports or something, though I haven't looked too closely at > > what's the issue. > >
