I sure hope that all tests are ALWAYS run by default in the 2.x branch, otherwise it will be a -1 from me.
Gary On Fri, Jun 14, 2024, 11:07 AM <pkarw...@apache.org> wrote: > This is an automated email from the ASF dual-hosted git repository. > > pkarwasz pushed a commit to branch 2.x > in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git > > > The following commit(s) were added to refs/heads/2.x by this push: > new 0bc5b99731 Disable PTS on a per-module basis > 0bc5b99731 is described below > > commit 0bc5b99731f60035a725c96781e6f07e8c9e505d > Author: Piotr P. Karwasz <piotr.git...@karwasz.org> > AuthorDate: Fri Jun 14 17:06:33 2024 +0200 > > Disable PTS on a per-module basis > --- > .github/workflows/build.yaml | 1 - > .github/workflows/merge-dependabot.yaml | 1 - > log4j-jul/pom.xml | 3 +++ > pom.xml | 8 ++++++++ > 4 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml > index d2f5515c85..43e859cf60 100644 > --- a/.github/workflows/build.yaml > +++ b/.github/workflows/build.yaml > @@ -39,7 +39,6 @@ jobs: > 8 > 17 > site-enabled: true > - predictive-test-selection-enabled: true > > deploy-snapshot: > needs: build > diff --git a/.github/workflows/merge-dependabot.yaml > b/.github/workflows/merge-dependabot.yaml > index efa3a067e0..a2a8f1f52e 100644 > --- a/.github/workflows/merge-dependabot.yaml > +++ b/.github/workflows/merge-dependabot.yaml > @@ -38,7 +38,6 @@ jobs: > java-version: | > 8 > 17 > - predictive-test-selection-enabled: true > > merge-dependabot: > needs: build > diff --git a/log4j-jul/pom.xml b/log4j-jul/pom.xml > index 8f96b2a9cf..60672017a8 100644 > --- a/log4j-jul/pom.xml > +++ b/log4j-jul/pom.xml > @@ -36,6 +36,9 @@ > <!-- Log4j Core is optional --> > org.apache.logging.log4j.core.*;resolution:=optional > </bnd-extra-package-options> > + > + <!-- PTS requires using the JUnit Platform, which interferes with JUL > initialization --> > + > <predictive.test.selection.enabled>false</predictive.test.selection.enabled> > </properties> > > <dependencies> > diff --git a/pom.xml b/pom.xml > index 197ffa7dc0..f795bafe56 100644 > --- a/pom.xml > +++ b/pom.xml > @@ -319,6 +319,9 @@ > Hence, *DO NOT MANUALLY EDIT THIS VALUE*! --> > > > <project.build.outputTimestamp>2024-03-06T09:31:11Z</project.build.outputTimestamp> > > + <!-- Enables Predictive Test Selection for the project --> > + > <predictive.test.selection.enabled>true</predictive.test.selection.enabled> > + > <!-- ======================== > Site-specific properties > ======================== --> > @@ -597,6 +600,11 @@ > <artifactId>maven-surefire-plugin</artifactId> > <configuration> > <forkCount>1C</forkCount> > + <properties> > + <predictiveSelection> > + <enabled>${predictive.test.selection.enabled}</enabled> > + </predictiveSelection> > + </properties> > <reuseForks>false</reuseForks> > <runOrder>alphabetical</runOrder> > <systemPropertyVariables> > >
