GitHub user swebb2066 added a comment to the discussion: Next Log4cxx Major release thoughts
While working on #601 I observed that Log4cxx currently breaks [the guideline to not call virtual functions in a destructor](https://codeql.github.com/codeql-query-help/cpp/cpp-virtual-call-in-constructor/). Derived appender destructors currently call [AppenderSkeleton::finalize](https://logging.apache.org/log4cxx/1.6.1/classlog4cxx_1_1AppenderSkeleton.html#af6d1ab262b89bbea3a1e90b571dd844f), which calls `close` in the derived Appender. Should this be changed? GitHub link: https://github.com/apache/logging-log4cxx/discussions/519#discussioncomment-16028913 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
