Thank you for the updated instructions. Please update the review kit
page at your convenience.

+1

Test summary: total: 351, failed: 0, succeeded: 338, skipped: 0, duration: 6.2s
Build succeeded with 17 warning(s) in 10.5s

Gary

On Tue, Aug 18, 2026 at 5:40 PM Jan Friedrich <[email protected]> wrote:
>
> Hi Gary,
>
> The instructions are missing a step. Dockerfile is at the root of the
> extracted source tree, and
> docker build . picks it up by its default name, so no filename is needed
> on the command line.
>
> What's missing is a cd: verify-release.sh extracts the source zip into
> ./src under the release directory, and
> because the script runs in a subshell its own cd doesn't carry over to
> your shell. So after verification you need:
>
> cd src
> docker build -t log4net-builder .
> docker run -it log4net-builder
>
> I've adjusted the release verification page accordingly.
>
> Jan
>
> On 8/18/26 22:58, Gary Gregory wrote:
> > Hi Jan,
> >
> > Are you sure the review kit is correct? Granted I am on macOS, but I get:
> >
> > docker build -t log4net-builder .
> >
> > [+] Building 0.0s (1/1) FINISHED
> >
> >                                                  docker:desktop-linux
> >   => [internal] load build definition from Dockerfile
> >
> >                                                                  0.0s
> >   => => transferring dockerfile: 2B
> >
> >                                                                  0.0s
> > ERROR: failed to build: failed to solve: failed to read dockerfile:
> > open Dockerfile: no such file or directory
> >
> > View build details:
> > docker-desktop://dashboard/build/desktop-linux/desktop-linux/abwoh4mzexkvcb6dyaf6qumg0
> >
> > Shouldn't the docker file name be on the command line somewhere?
> >
> > TY,
> > Gary
> >
> > On Tue, Aug 18, 2026 at 4:44 PM Jan Friedrich <[email protected]> wrote:
> >>
> >> This is a vote to release the Apache Log4net 3.4.0.
> >>
> >> Website: https://logging.staged.apache.org/log4net/release-notes.html
> >> GitHub: https://github.com/apache/logging-log4net
> >> Commit: 71c038c1860b331ca944840702d72da53e4cb41f
> >> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net/3.4.0
> >> Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D
> >> Review kit: https://logging.staged.apache.org/log4net/release-review.html
> >>
> >> Please download, test, and cast your votes on this mailing list.
> >>
> >> [ ] +1, release the artifacts
> >> [ ] -1, don't release, because ...
> >>
> >> This vote is open for 72 hours and will pass unless getting a net
> >> negative vote count.
> >> All votes are welcome and we encourage everyone to test the release, but
> >> only the Logging Services PMC votes are officially counted.
>

Reply via email to