ppkarwasz commented on PR #6: URL: https://github.com/apache/logging-flume-rpc/pull/6#issuecomment-5671992793
Most of the changes were identical to #5. The only remaining change was the Thrift upgrade. I refactored it a little bit to: 1. Download and validate a `thrift` compiler. 2. Run it with `generated_annotations=suppress`. 3. Pass it to OpenRewrite to remove the dependency on SLF4J. 4. Format everything with Spotless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
