GitHub user swebb2066 added a comment to the discussion: Next Log4cxx Major release thoughts
I believe the Appender::requiresLayout() virtual method should be removed (as happened in Log4j2). The only current usage is in PropertyConfigurator, and this test only ever prevents a layout configuration from being added to an appender. Removing it from the Appender interface would require changing every user-defined Appender subclass. Retaining it as a non-virtual method doesn't seem to achieve anything. I propose we retain it as a virtual method, add a @deprecated tag and implement a stub in appender.cpp. Thoughts? GitHub link: https://github.com/apache/logging-log4cxx/discussions/519#discussioncomment-19483679 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
