[ 
https://issues.apache.org/jira/browse/LUCENE-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868358#action_12868358
 ] 

Robert Muir commented on LUCENE-2466:
-------------------------------------

I talked to Hoss Man about some of these date problems, and he was of the 
opinion that for Solr, the Locale should never be used for date 
parsing/formatting (only standard UTC/Locale.US). So these are easy to fix.

But there is another problem, in this case the formats of floats themselves. 
Should they follow the same rule in Solr, or should localized numerics formats 
be supported? 

{noformat}
   [junit] Caused by: java.lang.NumberFormatException: For input string: "<some 
thai digits here>"
   [junit]     at 
sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1224)
   [junit]     at java.lang.Float.parseFloat(Float.java:422)
   [junit]     at 
org.apache.solr.util.NumberUtils.float2sortableStr(NumberUtils.java:79)
   [junit]     at 
org.apache.solr.schema.SortableFloatField.toInternal(SortableFloatField.java:49)
   [junit]     at 
org.apache.solr.schema.FieldType.createField(FieldType.java:236)
   [junit]     ... 38 more
   [junit] </result>)
{noformat}

Furthermore, what about DataImportHandlers use of some of the same 
DateMathParser stuff used in other places in Solr? It tends to use 
TimeZone.getDefault/Locale.getDefault... should this be changed?


> fix some more locale problems in lucene/solr
> --------------------------------------------
>
>                 Key: LUCENE-2466
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2466
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-2466.patch, LUCENE-2466.patch, 
> LUCENE-2466_coretests.patch, LUCENE-2466_lucene_thai.patch
>
>
> set ANT_ARGS="-Dargs=-Duser.language=tr -Duser.country=TR"
> ant clean test
> We should make sure this works across all of lucene/solr

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to