[ 
https://issues.apache.org/jira/browse/SOLR-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889332#action_12889332
 ] 

Robert Muir commented on SOLR-2002:
-----------------------------------

bq. the purpose of those tests is not just to test Jetty - it's to test that 
the example configs load and are usable.

This is messy and should be fixed: these are jetty tests. If you truly believe 
this (I think you are wrong), then we should do the following:

If the example config should be tested to be loaded and usable:

# it should not be mixed in jetty tests, this is wrong! (as the comment 
describes)
# we should create a TestExampleConfig, and its purpose is to test various 
things about the example config, nothing more.
# the example config used in said tests shouldnt load up shit from contrib.

> improve build/tests
> -------------------
>
>                 Key: SOLR-2002
>                 URL: https://issues.apache.org/jira/browse/SOLR-2002
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2002.patch, SOLR-2002_core_contrib.patch, 
> SOLR-2002setupteardown.patch
>
>
> we are working on improving some functionality in lucene's build/tests, it 
> would be good to improve the solr side to take advantage of it.
> currently its only sorta-kinda integrated and a bit messy.
> i'd like to do some incremental improvements piece-by-piece on this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to