TopDocsCollector should be abstract super class that is the real "TopDocsCollector" contract, a subclass should implement the priority-queue logic. e.g. PQTopDocsCollector ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: LUCENE-2542 URL: https://issues.apache.org/jira/browse/LUCENE-2542 Project: Lucene - Java Issue Type: Improvement Components: Search Affects Versions: 3.0.2 Reporter: Woody Anderson Fix For: 4.0, 3.0.2 TopDocsCollector is both an abstract interface for producing TopDocs as well as a PriorityQueue based implementation. Not all Collectors that could produce TopDocs must use a PriorityQueue, and it would be advantageous to allow the TopDocsCollector to be an "interface" type abstract class, with a PQTopDocsCollector sub-class. While doing this, it'd be good to clean up the generics uses in these classes. As it's odd to create a TopFieldCollector and have to case the TopDocs object, when this can be fixed with generics. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org