[ 
https://issues.apache.org/jira/browse/SOLR-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898110#action_12898110
 ] 

Martijn van Groningen commented on SOLR-1682:
---------------------------------------------

Cool stuff Yonik! I noticed in the SolrIndexSearcher#groupBy method that you 
were instantiating a Lucene filter from the filer docset but you are not using 
it as argument to the search method, so if some specifies a fq it would not 
work. I'll dive deeper into the patch in the next few days.

> Implement CollapseComponent
> ---------------------------
>
>                 Key: SOLR-1682
>                 URL: https://issues.apache.org/jira/browse/SOLR-1682
>             Project: Solr
>          Issue Type: Sub-task
>          Components: search
>            Reporter: Martijn van Groningen
>            Assignee: Shalin Shekhar Mangar
>             Fix For: Next
>
>         Attachments: field-collapsing.patch, SOLR-1682.patch, 
> SOLR-1682.patch, SOLR-1682.patch, SOLR-1682_prototype.patch, 
> SOLR-1682_prototype.patch, SOLR-1682_prototype.patch, SOLR-236.patch
>
>
> Child issue of SOLR-236. This issue is dedicated to field collapsing in 
> general and all its code (CollapseComponent, DocumentCollapsers and 
> CollapseCollectors). The main goal is the finalize the request parameters and 
> response format.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to