[
https://issues.apache.org/jira/browse/LUCENE-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-2598:
---------------------------------------
Attachment: LUCENE-2598.patch
Some more fixes to try to make tests run faster w/
-Dtests.directory=SimpleFSDir.
Also, I changed FSDir.length -- previously it first checked if the file exists
and then checks the size. I reversed this check, since presumably it's far
more common that this method is called w/ a real (existing) file. Only if
length comes back as 0 do I then check if it exists.
> allow tests to use different Directory impls
> --------------------------------------------
>
> Key: LUCENE-2598
> URL: https://issues.apache.org/jira/browse/LUCENE-2598
> Project: Lucene - Java
> Issue Type: Test
> Components: Build
> Affects Versions: 3.1, 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2598.patch, LUCENE-2598.patch, LUCENE-2598.patch,
> LUCENE-2598.patch, LUCENE-2598.patch
>
>
> Now that all tests use MockRAMDirectory instead of RAMDirectory, they are all
> picky like windows and force our tests to
> close readers etc before closing the directory.
> I think we should do the following:
> # change new MockRAMDIrectory() in tests to .newDirectory(random)
> # LuceneTestCase[J4] tracks if all dirs are closed at tearDown and also
> cleans up temp dirs like solr.
> # factor out the Mockish stuff from MockRAMDirectory into MockDirectoryWrapper
> # allow a -Dtests.directoryImpl or simpler to specify the default Directory
> to use for tests: default being "random"
> i think theres a chance we might find some bugs that havent yet surfaced
> because they are easier to trigger with FSDir
> Furthermore, this would be beneficial to Directory-implementors as they could
> run the entire testsuite against their Directory impl, just like
> codec-implementors can do now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
