[
https://issues.apache.org/jira/browse/LUCENE-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910089#action_12910089
]
Michael McCandless commented on LUCENE-2647:
--------------------------------------------
bq. What about TermsIndexWriter/ReaderBase since we started using that scheme
with analyzers and the JDK uses that too.
OK I'll switch from Abstract* -> *Base.
{quote}
bq. SimpleStandardTermsIndexWriter/Reader -> SimpleTermsIndexWriter/Reader
I really don't like Simple* its like Smart which makes me immediately feel
itchy all over the place.
{quote}
Heh OK.
bq. What differentiates this from others? It is the default? maybe
DefaultTermsIndexWriter/Reader?
Well... there are no "others" yet! So, its is the default for now, but, I
don't like baking that into its name...
Lesse... so this one uses packed ints, to write the "RAM image" required at
search time, so that at search time we just slurp in these pre-built images.
While the index term selection policy is now "fixed" (every N), I think this
may change with time (the policy should be easily separable from how the index
terms are written). Though, since we haven't yet done that separation, maybe I
simply name it FixedGapTermsIndexWriter/Reader? How's that?
> Move & rename the terms dict, index, abstract postings out of
> oal.index.codecs.standard
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-2647
> URL: https://issues.apache.org/jira/browse/LUCENE-2647
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 4.0
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2647.patch
>
>
> The terms dict components that current live under Standard codec
> (oal.index.codecs.standard.*) are in fact very generic, and in no way
> particular to the Standard codec. Already we have many other codecs
> (sep, fixed int block, var int block, pulsing, appending) that re-use
> the terms dict writer/reader components.
> So I'd like to move these out into oal.index.codecs, and rename them:
> * StandardTermsDictWriter/Reader -> PrefixCodedTermsWriter/Reader
> * StandardTermsIndexWriter/Reader -> AbstractTermsIndexWriter/Reader
> * SimpleStandardTermsIndexWriter/Reader -> SimpleTermsIndexWriter/Reader
> * StandardPostingsWriter/Reader -> AbstractPostingsWriter/Reader
> * StandardPostingsWriterImpl/ReaderImple -> StandardPostingsWriter/Reader
> With this move we have a nice reusable terms dict impl. The terms
> index impl is still well-decoupled so eg we could [in theory] explore
> a variable gap terms index.
> Many codecs, I expect, don't need/want to implement their own terms
> dict....
> There are no code/index format changes here, besides the renaming &
> fixing all imports/usages of the renamed class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
