[
https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914044#action_12914044
]
Yonik Seeley commented on LUCENE-2649:
--------------------------------------
Now we're talking!
Q: why aren't the CachePopulator methods just directly on EntryConfig - was it
easier to share implementations that way or something?
Also:
- It doesn't seem like we need two methods fillValidBits , fillByteValues -
shouldn't it just be one method that looks at the config and fills in the
appropriate entries based on cacheValidBits() and cacheValues()?
- We should allow an implementation to create subclasses of ByteValues, etc...
what about this method:
public abstract CachedArray fillEntry( CachedArray vals, IndexReader
reader, String field, EntryConfig creator )
That way, an existing entry can be filled in (i.e. vals != null) or a new entry
can be created.
Oh, wait, I see further down a "ByteValues createValue()" - if that's meant to
be a method on CachePopulator, I guess it's all good - my main concern was
being able to create subclasses of ByteValues and frields.
Anyway, all that's off the top of my head - I'm sure you've thought about it
more at this point.
> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>
> Key: LUCENE-2649
> URL: https://issues.apache.org/jira/browse/LUCENE-2649
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
> Attachments: LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch
>
>
> The FieldCache returns an array representing the values for each doc.
> However there is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a
> BitSet for all valid docs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
