[
https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914959#action_12914959
]
Michael McCandless commented on LUCENE-2649:
--------------------------------------------
bq. Apologies for 'CTR' rather then 'RTC' -- we can always revert if I jumped
the gun!
Better to ask forgiveness than permission :)
In fact I'm +1 on switching Lucene's trunk to CTR model instead, now
that we have 3.x as the stable branch. We have enough "policemen"
around here that I think this'd work well.
The changes look great Ryan -- nice work!
Some smallish feedback:
* I see some windows eol's snuck in... can you change the
svn:eol-style of all the new sources to "native"?
* Some classes are missing copyright header (at least EntryKey,
SimpleEntryKey)
* Shouldn't we only incr .numDocs if the bit wasn't already set?
(To be robust if docs have more than one value). Ie we can use
OpenBits.getAndSet. Maybe then add and assert that numDoc <=
maxDoc in the end...
* Then, we can pass null for the delDocs to the enums, and then we
don't need a 2nd pass to detect matchAllDocs (just test if
.numDocs == maxDoc())?
I think we should hold off on backport to 3.x until we stabilize
LUCENE-2665?
It looks like you've also fixed LUCENE-2527 with this? Ie the
fasterButMoreRAM=true|false now cache to the same key? It's just that
perhaps we should "upgrade" the entry, if it was first created w/
false and then the current call passes true?
> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>
> Key: LUCENE-2649
> URL: https://issues.apache.org/jira/browse/LUCENE-2649
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 4.0
>
> Attachments: LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch
>
>
> The FieldCache returns an array representing the values for each doc.
> However there is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a
> BitSet for all valid docs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
