[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915968#action_12915968 ]
Yonik Seeley commented on SOLR-1568: ------------------------------------ bq. All I can find are nits about comparing doubles and printed doubles directly. Yep - me too. Not an easy fix currently (junit can compare w/ epsilon, but you need the actual double values, which we don't have). I don't think xpath has epsilon comparison methods, but I was thinking of somehow adding epsilon support (maybe just global to start) to the json-testing framework I've been slowly building out. Prob won't get to it until tests break due to the brittleness ;-) > Implement Spatial Filter > ------------------------ > > Key: SOLR-1568 > URL: https://issues.apache.org/jira/browse/SOLR-1568 > Project: Solr > Issue Type: New Feature > Reporter: Grant Ingersoll > Assignee: Grant Ingersoll > Priority: Minor > Fix For: 3.1, 4.0 > > Attachments: CartesianTierQParserPlugin.java, > SOLR-1568.Mattmann.031010.patch.txt, SOLR-1568.patch, SOLR-1568.patch, > SOLR-1568.patch, SOLR-1568.patch, SOLR-1568.patch, SOLR-1568.patch, > SOLR-1568.patch, SOLR-1568.patch, SOLR-1568.patch, SOLR-1568.patch, > SOLR-1568.patch, SOLR-1568.patch, SOLR-1568.patch, SOLR-1568.patch, > SOLR-1568.patch, SOLR-1568.patch, SOLR-1568.patch, SOLR-1568.patch, > SOLR-1568.patch > > > Given an index with spatial information (either as a geohash, > SpatialTileField (see SOLR-1586) or just two lat/lon pairs), we should be > able to pass in a filter query that takes in the field name, lat, lon and > distance and produces an appropriate Filter (i.e. one that is aware of the > underlying field type for use by Solr. > The interface _could_ look like: > {code} > &fq={!sfilt dist=20}location:49.32,-79.0 > {code} > or it could be: > {code} > &fq={!sfilt lat=49.32 lat=-79.0 f=location dist=20} > {code} > or: > {code} > &fq={!sfilt p=49.32,-79.0 f=location dist=20} > {code} > or: > {code} > &fq={!sfilt lat=49.32,-79.0 fl=lat,lon dist=20} > {code} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org