On Wed, Oct 20, 2010 at 7:01 AM, Grant Ingersoll <[email protected]> wrote:
> Couldn't 3.x move contrib/analysis to modules? We could just move it to > contrib as part of the release packaging if the goal is to be consistent, > but otherwise who cares where it is located? > > Would that reduce some of this? > I don't think it would help so much, because the analyzers in modules did not come just from contrib/analyzers... but from lucene's core (individual files cherrypicked, things like TokenStream still stay), contrib/icu, and from Solr (the factories stay at the moment though). thats just what i mean though, if we will make lucene more modular i think this is just a very typical case of consolidating things from different places in lucene/solr and modularizing it, so thats why I think a lot of it is unavoidable. Uwe says single-file merges are a no-go, but (hypothetically) if we moved just the concrete Queries from o.a.l.search (but not everything else!), and the Queries in contrib/queries into a modules/queries, then you would end up with the same situation... if you fix a bug in modules/queries/TermQuery you have to merge the individual file in 3.x's src/java because the entire o.a.l.search did not move, only a few cherrypicked files (the queries). --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
