[
https://issues.apache.org/jira/browse/LUCENE-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923550#action_12923550
]
Uwe Schindler commented on LUCENE-2716:
---------------------------------------
It still creates lots of objects depending on the size and states of the
automaton, but a lot less!
If I will look several times over it, I may find more improvements. :-)
The Hopcroft-Policeman
> Improve automaton's MinimizeOperations.minimizeHopcroft() to not create so
> many objects
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-2716
> URL: https://issues.apache.org/jira/browse/LUCENE-2716
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2716.patch
>
>
> MinimizeOperations.minimizeHopcroft() creates a lot of objects because of
> strange arrays and useless ArrayLists with fixed length. E.g. it created
> List<List<List<>>>. This patch minimizes this and makes the whole method much
> more GC friendler by using simple arrays or avoiding empty LinkedLists at all
> (inside reverse array).
> minimize() is called very very often, especially in tests (MockAnalyzer).
> A test for the method is prepared by Robert, we found a bug somewhere else in
> automaton, so this is pending until his issue and fix arrives.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
