[
https://issues.apache.org/jira/browse/LUCENE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865677#comment-13865677
]
Robert Muir commented on LUCENE-5388:
-------------------------------------
{quote}
Do we change #create to not take a reader, or do we add 'throws IOException'?
Based on comments above, I'd think we take out the reader.
{quote}
Yes, please. its not like a factory can do anything fancy with it anyway: its
only called the first time, subsequent readers are invoked with setReader. so
this is just more of the same, please nuke it!
> Eliminate construction over readers for Tokenizer
> -------------------------------------------------
>
> Key: LUCENE-5388
> URL: https://issues.apache.org/jira/browse/LUCENE-5388
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Reporter: Benson Margulies
>
> In the modern world, Tokenizers are intended to be reusable, with input
> supplied via #setReader. The constructors that take Reader are a vestige.
> Worse yet, they invite people to make mistakes in handling the reader that
> tangle them up with the state machine in Tokenizer. The sensible thing is to
> eliminate these ctors, and force setReader usage.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
