[ 
https://issues.apache.org/jira/browse/SOLR-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865874#comment-13865874
 ] 

Joel Bernstein commented on SOLR-5230:
--------------------------------------

Steve, 

I think this is done properly, but I haven't added any test cases for this yet.

We'd need to mock up a simple PostFilter that uses finish() for the tests 
because the CollapsingQParserPlugin is the only PostFilter right now that 
relies on finish(). It would be better to mockup a simple test PostFilter for 
the tests.

Joel

> Call DelegatingCollector.finish() during grouping
> -------------------------------------------------
>
>                 Key: SOLR-5230
>                 URL: https://issues.apache.org/jira/browse/SOLR-5230
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 4.4
>            Reporter: Joel Bernstein
>            Priority: Minor
>             Fix For: 4.7
>
>         Attachments: SOLR-5230.patch
>
>
> This is an add-on to SOLR-5020 to call the new DelegatingCollector.finish() 
> method from inside the grouping flow. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to