[ https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884356#comment-13884356 ]
Steve Rowe edited comment on LUCENE-5353 at 1/28/14 5:45 PM: ------------------------------------------------------------- Thanks for the patch, Ahmet. Attaching a new patch with a few minor mods: # {{setFillerToken()}} now takes a {{String}} instead of a {{char[]}}, which was awkward. # when arg to {{setFillerToken()}} is {{null}}, set the filler token to {{new char\[0]}}. # beefed up javadocs # added tests for zero-length and {{null}} args to {{setFillerToken()}}. I think it's ready to go. was (Author: steve_rowe): Thanks for the patch, Arslan. Attaching a new patch with a few minor mods: # {{setFillerToken()}} now takes a {{String}} instead of a {{char[]}}, which was awkward. # when arg to {{setFillerToken()}} is {{null}}, set the filler token to {{new char\[0]}}. # beefed up javadocs # added tests for zero-length and {{null}} args to {{setFillerToken()}}. I think it's ready to go. > ShingleFilter should have a way to specify FILLER_TOKEN > ------------------------------------------------------- > > Key: LUCENE-5353 > URL: https://issues.apache.org/jira/browse/LUCENE-5353 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis > Affects Versions: 4.6 > Reporter: Simon Willnauer > Fix For: 5.0, 4.7 > > Attachments: LUCENE-5353.patch, LUCENE-5353.patch > > > Today we have no choice that if pos_inc is > 1 there will be a `_` inserted > in between the tokens. We should have the ability to change this character > and the char[] that holds it should not be public static since it's mutable. -- This message was sent by Atlassian JIRA (v6.1.5#6160) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org