[ 
https://issues.apache.org/jira/browse/SOLR-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vitaliy Zhovtyuk updated SOLR-5257:
-----------------------------------

    Attachment: SOLR-5257.patch

Fixed warning messages
I have not added TODOs, but few if's in this class can be replaced with switch 
for clarity: starting at lines 221, 233, 299
Maybe improve this in future.


> confusing warning logged when unexpected xml attributes are found
> -----------------------------------------------------------------
>
>                 Key: SOLR-5257
>                 URL: https://issues.apache.org/jira/browse/SOLR-5257
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Minor
>         Attachments: SOLR-5257.patch
>
>
> Brian Robinson on the solr-user list got really confused by this warning 
> message...
> {{Unknown attribute id in add:allowDups}}
> ...the mention of "id" in that warning was a big red herring that led him to 
> assume something was wrong with the "id" in his documents, because it's not 
> at all clear that's refering to the "xml node id" of an unexpected "xml 
> attribute" (which in this case is "allowDups")
> filing this issue so i remembe to fix this warning to be more helpful, and 
> review the rest of the file while i'm at it for other confusing warnings.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to