[ 
https://issues.apache.org/jira/browse/LUCENE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890703#comment-13890703
 ] 

ASF subversion and git services commented on LUCENE-5431:
---------------------------------------------------------

Commit 1564305 from [~shaie] in branch 'dev/branches/branch_4x'
[ https://svn.apache.org/r1564305 ]

LUCENE-5431: add FSLockFactory.toString() and fix FilterDirectory to override 
getLockID(); also change FSDirectory.toString() to use class.getSimpleName()

> Add FSLockFactory.toString()
> ----------------------------
>
>                 Key: LUCENE-5431
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5431
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/store
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-5431.patch, LUCENE-5431.patch
>
>
> FSLockFactory doesn't override toString, which causes Dir.toString() to print 
> the class.name@instance. I think it would be better if it printed e.g. the 
> lockDir.
> I added it but TestCrashCausesCorruptIndex failed because it declares a 
> Directory which doesn't override getLockID(), which returns toString(). I 
> changed that Directory to extend FilterDirectory, and fixed FilterDirectory 
> to override getLockID() to call in.getLockID().
> Will attach a patch shortly.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to