[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891044#comment-13891044 ]
Lei Wang commented on LUCENE-5425: ---------------------------------- The overhead may not from the additional method call, might be the openbitset, the impl in the fixedbitset is more friendly to branching predict and instructions prefetching. But I think we can simply apply the reuse part now first. I will start run some more tests later on when i get time. I actually have an idea now to apply the optimization in general which I thought might only be applied in our case previously. will also test that out, see if we can improve this overall. > Make creation of FixedBitSet in FacetsCollector overridable > ----------------------------------------------------------- > > Key: LUCENE-5425 > URL: https://issues.apache.org/jira/browse/LUCENE-5425 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Affects Versions: 4.6 > Reporter: John Wang > Attachments: facetscollector.patch, facetscollector.patch, > fixbitset.patch > > > In FacetsCollector, creation of bits in MatchingDocs are allocated per query. > For large indexes where maxDocs are large creating a bitset of maxDoc bits > will be expensive and would great a lot of garbage. > Attached patch is to allow for this allocation customizable while maintaining > current behavior. -- This message was sent by Atlassian JIRA (v6.1.5#6160) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org