[
https://issues.apache.org/jira/browse/LUCENE-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892436#comment-13892436
]
Michael McCandless commented on LUCENE-5434:
--------------------------------------------
Patch looks good!
Yes, any test pulling non-NRT readers cannot enable the new
MDW.assertNoDeleteOpenFile... but if the test is only pulling NRT readers, we
should enable the assert. TestNRTReaderWithThreads is a good start.
Hmm, why did you need to change MDW.close? Actually, why does MDW.close() even
check noDeleteOpenFile when throwing exc because files are still open...?
Shouldn't it always throw an exc if there are still open files (or, open
locks)? Tests seem to pass when I remove that, at least once :)
> NRT support for file systems that do no have delete on last close or cannot
> delete while referenced semantics.
> --------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-5434
> URL: https://issues.apache.org/jira/browse/LUCENE-5434
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5434.patch, LUCENE-5434.patch
>
>
> See SOLR-5693 and our HDFS support - for something like HDFS to work with
> NRT, we need an ability for near realtime readers to hold references to their
> files to prevent deletes.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
