[ https://issues.apache.org/jira/browse/LUCENE-5436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893577#comment-13893577 ]
Michael McCandless commented on LUCENE-5436: -------------------------------------------- Hmm, sneaky. So we are adding best-effort catching of this mis-use? Instead of isClosed can we add protected getRefCount? That's just more consistent with the current abstract methods we already have? There's a small typo in the exception message (then -> the). > RefrenceManager#accquire can result in infinite loop if manager resource is > abused outside of the manager > --------------------------------------------------------------------------------------------------------- > > Key: LUCENE-5436 > URL: https://issues.apache.org/jira/browse/LUCENE-5436 > Project: Lucene - Core > Issue Type: Bug > Components: core/search > Affects Versions: 4.6.1, 5.0, 4.7 > Reporter: Simon Willnauer > Fix For: 5.0, 4.7 > > Attachments: LUCENE-5436.patch > > > I think I found a bug that can cause the ReferenceManager to stick in an > infinite loop if the managed reference is decremented outside of the manager > without a corresponding increment. I think this is pretty bad since the > debugging of this is a mess and we should rather throw ISE instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org