[ 
https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897949#comment-13897949
 ] 

Shai Erera commented on LUCENE-5440:
------------------------------------

bq. I don't think FixedBitSet should be external.

+1. I mistakenly removed the \@lucene.internal annotation, will add it back in 
the new patch. Our API isn't FixedBitSet, it's Filter/DocIdSet. And we offer 
DocIdBitSet (external) to use w/ Java's BitSet. It's not true that users cannot 
write their own Filters - they can write them using DocIdBitSet, or risk and 
use the internal FixedBitSet. I wouldn't want to see FBS stays w/ that name, 
just because once there was OpenBitSet - renaming (just as removing 'extends 
DocIdSet') is a trivial change to your code when you migrate...

> Add LongFixedBitSet and replace usage of OpenBitSet
> ---------------------------------------------------
>
>                 Key: LUCENE-5440
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5440
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-5440-solr.patch, LUCENE-5440.patch, 
> LUCENE-5440.patch, LUCENE-5440.patch, LUCENE-5440.patch, LUCENE-5440.patch
>
>
> Spinoff from here: http://lucene.markmail.org/thread/35gw3amo53dsqsqj. I 
> wrote a LongFixedBitSet which behaves like FixedBitSet, only allows managing 
> more than 2.1B bits. It overcome some issues I've encountered with 
> OpenBitSet, such as the use of set/fastSet as well the implementation of 
> DocIdSet. I'll post a patch shortly and describe it in more detail.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to