[ 
https://issues.apache.org/jira/browse/SOLR-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899183#comment-13899183
 ] 

Joel Bernstein commented on SOLR-5624:
--------------------------------------

The previous commit checks for elevated documents in the query's hashCode() 
method. This needs to be done because elevated documents do not appear in the 
request context until after the query is constructed. This is because the 
QueryElevationComponent adds the elevated documents to the request context 
after the original query is constructed.

When checking for the query in the QueryResultCache, we need to take into 
account the presence of elevated documents. The check that was added to the 
hashCode() method does this.

We still need to look for elevated docs in the getFilterCollector() method in 
case caching was turned off.

> Enable QueryResultCache for CollapsingQParserPlugin
> ---------------------------------------------------
>
>                 Key: SOLR-5624
>                 URL: https://issues.apache.org/jira/browse/SOLR-5624
>             Project: Solr
>          Issue Type: Task
>    Affects Versions: 4.6
>            Reporter: David
>            Assignee: Joel Bernstein
>             Fix For: 5.0, 4.7
>
>         Attachments: SOLR-5624.patch, SOLR-5624.patch, SOLR-5624.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to