[ https://issues.apache.org/jira/browse/LUCENE-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13901389#comment-13901389 ]
Simon Willnauer edited comment on LUCENE-5444 at 2/14/14 12:41 PM: ------------------------------------------------------------------- Hey Britta, the parameter should be _offsetGap_ rather than _positionIncrementGap_ no? {noformat} public void setOffsetGap(int positionIncrementGap){ {noformat} bq. Can you hint at what exactly I should be testing? you are passing an random offset (btw. the Math.abs call is not needed since it should give you a positive int anyways) to the mock analyzer that is what I meant by testing the offset gap. please just fix that parameter name and I think we are good to go! thanks for fixing all the stuff so quickly! was (Author: simonw): Hey Britta, the parameter should be _offsetGap_ rather than _positionIncrementGap_ no? {noformat} public void setOffsetGap(int positionIncrementGap){ {noformat} bq. . Can you hint at what exactly I should be testing? you are passing an random offset (btw. the Math.abs call is not needed since it should give you a positive int anyways) to the mock analyzer that is what I meant by testing the offset gap. please just fix that parameter name and I think we are good to go! thanks for fixing all the stuff so quickly! > offsets in MemoryIndex broken when adding field with more than once > ------------------------------------------------------------------- > > Key: LUCENE-5444 > URL: https://issues.apache.org/jira/browse/LUCENE-5444 > Project: Lucene - Core > Issue Type: Bug > Components: core/index > Affects Versions: 4.6.1 > Reporter: britta weber > Assignee: Simon Willnauer > Priority: Minor > Labels: easyfix > Fix For: 5.0, 4.7 > > Attachments: LUCENE-5444.patch, LUCENE-5444.patch > > Original Estimate: 168h > Remaining Estimate: 168h > > When fields with the same name are added more than once to MemoryIndex, the > offsets of the previous additions of the field do not seem to be taken into > account. As a result, MemoryIndex cannot be used for example with the vector > highlighter. -- This message was sent by Atlassian JIRA (v6.1.5#6160) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org