[
https://issues.apache.org/jira/browse/LUCENE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904638#comment-13904638
]
David Smiley commented on LUCENE-5451:
--------------------------------------
I'd just like to take a moment to clarify some things for [~simonw] -- we were
chatting in IRC but needed to sign off for the night. Others may be curious.
Firstly, Spatial4j has its own tests using the same extensive randomization
methodology & actual libraries (JUnit & RandomizedTesting) that Lucene uses,
and it's run by CI -- TravisCI. I fixed the aforementioned bug and it has a
test now to catch potential regressions. Even if Lucene could test this
particular bug (it can't due to needing JTS; see next paragraph), I don't think
that it's needed since it's already tested somewhere (Spatial4j's tests
itself). That said, I'd love to incorporate some JTS using tests in Lucene
that exercise various things at once (sort of an integration test) including
definitely what this bug is related to.
Until JTS is relicensed to Eclipse Public License (which is pending to occur
sometime this year) Lucene can't use it, and AFAIK we're not even permitted to
put it on the test classpath (right?). It wouldn't be a test
compile-dependency; it needs to be available at runtime so Spatial4j can use
it. Perhaps Lucene's Jenkins can put it on the classpath when it runs tests?
[~thetaphi] what do you think? There does exist one test which uses
{{assumeTrue(...check for JTS...);}} --
[JtsPolygonTest|https://github.com/apache/lucene-solr/blob/trunk/lucene/spatial/src/test/org/apache/lucene/spatial/prefix/JtsPolygonTest.java?source=cc#L52]
and in practice they never get run.
> Update Spatial4j to 0.4.1
> -------------------------
>
> Key: LUCENE-5451
> URL: https://issues.apache.org/jira/browse/LUCENE-5451
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Affects Versions: 4.7, 5.0
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Blocker
> Fix For: 4.7, 5.0
>
>
> A user reported a fairly serious issue affecting the latest version of
> Spatial4j 0.4
> https://github.com/spatial4j/spatial4j/issues/72 "JtsSpatialContextFactory
> and geo=false with worldBounds fails"
> I've already fixed this locally and I'll push out a bug-fix Spatial4j 0.4.1.
> Upgrading will be a complete drop-in replacement. Heck I could do that now
> but as I work with the user who found the bug I want to see if there's any
> other problem.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
